Spell Parser Vs. Wiki Spell Page

Daffie

Daffie

Dalayan Pious Diety
So, I was poking around the spell parser a little bit to see what it is all about.

I found a bit of information displaying incorrectly (increase vs decrease haste...), and that prompted me to compare against the Wiki. The same spell has different information from the parser to the Wiki. As you can see below, the red text shows differences, the blue test shows missing data points between the two, and the green text shows blatantly incorrect data. I don't know how the spell pages work on the Wiki, but I was not able to 'edit' the page to see what the operator error was about.

This is the only spell I looked at, but if it happens in one spot, it is happening elsewhere.

Wiki:
Spell: Empower
Jump to: navigation, search
Classes: ENC(64) Spell ID: 1170
Spell Category: Utility Beneficial (Haste)
Mana cost: 165 Range: 100 Spell skill: Alteration
Cast time: 5.25 seconds AE radius: 0 Resist type: Unresistable
Recharge time: Instant AE duration: 0 Resist adjust: 0
Duration: 1800 ticks (3 hours) Target type: Single Restrictions: None
Reagents:
Not specified
Push back: 0 Auto Cast: Not specified
Spell Type: Beneficial
Effects (from parser):

Slot 1: Increase Attack Speed by 60%
Slot 2: Increase AGI by 57
Slot 3: Increase Armor Class by Expression error: Unexpected ( operator
Slot 4: Increase Stamina Regeneration by 10

Cast on You: You feel your body pulse with energy.



Parser:
Empower
Mana Cost: 165 Type: Beneficial Target Type: All
Cast Time: 5.0 seconds Recast Time: 0.0 Skill: Alteration
Resist Type: N/A Resist Adj: N/A
Range: 100 AE Range: 0
Duration: 1800 ticks (3 hours) AE Duration: 0 Push: 0
Reagents: None
Classes: ENC(64)
Effects:
Slot 1: Decrease Melee Haste by 60% to 100%
Slot 2: Increase AGI by 25
Slot 3: Increase AC by 6
Slot 4: Decrease Stamina Loss by 10
Cast on You: You feel your body pulse with energy.
Cast on Other: Target 's body pulses with energy.
 
Last edited:
On the wiki:
Slot 3: Increase Armor Class by Expression error: Unexpected ( operator
Now displays as Slot 3: Increase Armor Class by 24.

That 24 is 86 before calculations. The fact that further calculations have to be done to AC is why there was an error - the string was input originally as a range. (See the issue with loops further down - its not actually a range.)

Attack Speed and Melee Haste are synonymous.

Auto Cast: Not specified this is generally deprecated, but still used for simplicity's sake to show the relationship between certain spells on the wiki. I don't believe its generally used in spells any longer (since lifetaps no longer take a buff slot, etc.)

The decreased vs increased thing is something the dev working on the official parser will have to fix. Its likely an issue with increase vs decrease with attack speed not working in the same way as the other increase/decrease things in the parser. I encountered this same issue when coding the wiki spell parser.

IIRC, the way melee haste/attack speed is parsed could easily account not only for this error but the fact that its shown as a range. The lack of a proper range restriction on AC on the wiki parser is what caused the string error there, so please don't think I'm casting any stones here.

I cannot account for the target difference. I do know the wiki occasionally has issues with specific restrictions (as a result of lack of information on that subject on my end when doing the original coding.)

I cannot account for the time difference. I double checked the wiki, and it still parses the same there. Perhaps some rounding on the new parser? Further examples would help nail it down.

The lack of Cast on Other was a choice I made, predicated on the template made by the wiki admin who came before me.

I'll freely admit that the wiki can be a BIT off, since I coded out the parser using what means I had available at the time, which didn't include any sort of method for performing loops. This resulted in some terrifying workarounds, such as this.
 
Last edited:
Just wanted to let you guys/girls who are working on this know what I noticed :) I could only wish I had enough free time to work on it myself :(
 
j883376 said:
The web spell parser is a relatively new project and while it works fairly well, there are of course some inconsistencies. It is however open source under the GPL so if you'd like to contribute to fixing issues, feel free to fork it, hack away, and make a pull request.

https://github.com/ShardsofDalaya/sod-spellparser
Click to expand...
Is anyone doing fixes or maintaining this? This seems right up there with how I am interested in contributing on the project.

Haynar
 
the client spell parser is definitely vastly superior at the moment, once you learn the few quirks of it, ie. how some values are changed (for instance, balance party health(x) is autocast spell[id] etc)its actually nearly 100% accurate
 
I forked the parser last night. Will get ruby on rails up and going tonight. Never used it before, so its new to me. Pretty straight forward so far from what I see. Had an audit last week and 3 sick kids this past weekend, but I hope to work on this some later this week.

Haynar
 
You must log in or register to reply here.
Back
Top Bottom